commit | 5444e0fd9beecbd06aca4d3d3aced9d76e1b8f9b | [log] [tgz] |
---|---|---|
author | Siye Liu <siliu@microsoft.com> | Mon Jun 06 15:34:57 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jun 06 15:34:57 2022 |
tree | c2fc771102a88c421614dd4156f647116e349672 | |
parent | b89c24a7ca0b943595677fa9af20d769b7158ea1 [diff] |
Set selection range after committed composition only for non-IME input Some voice input tools (Windows voice typing, Windows voice access) may set selection range after committed composition. However, IMEs may rely on selection state to work. The original CL set selection regardless of input method which caused regression in Korean IME. The fix for this issue is to only scope the original CL to non-IME input. Ideally, we should use |GUID_TFCAT_TIP_SPEECH| to determine if current input method is voice typing/voice access, however, |ITfInputProcessorProfileMgr::GetActiveProfile| only supports |GUID_TFCAT_TIP_KEYBOARD| according to https://docs.microsoft.com/en-us/windows/win32/api/msctf/nf-msctf-itfinputprocessorprofilemgr-getactiveprofile. For now, we use the API to determine if current input method is IME. Original CL: crrev.com/971181 (cherry picked from commit 78b86cae08358efb5f314f6234f0c9f7af15bb6f) Bug: 1329857 Change-Id: Idc7c43d5b807c3ccd65381b19f8d6f18617adca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3682653 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by: Yohei Yukawa <yukawa@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1010245} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3689702 Commit-Queue: Prudhvikumar Bommana <pbommana@google.com> Cr-Commit-Position: refs/branch-heads/5060@{#601} Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.