Google Git
Sign in
chromium / chromium / src / 54470e434239a76589d8cfe012d5f56f2dfc764d
commit54470e434239a76589d8cfe012d5f56f2dfc764d[log] [tgz]
authorLinyu He <linyuh@google.com>Tue Aug 26 16:37:32 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Aug 26 16:37:32 2025
tree0e7953796c50c284b7cc5748e6fa2245b43495bd
parentd0993f1e71e72b44794a1f6220ddcf70d3958c46 [diff]
Android TabModel: only include "browser_window/*" on desktop Android

Context:

(1) Definitions of "browser_window/*" headers are available on desktop
Android, but not other Android builds.

(2) Android TabModel is for all Android builds, and currently
"browser_window/*" headers are included without a build flag check. This
will cause confusing linker errors if non-desktop Android builds use
symbols in "browser_window/*" headers.

Point (1) above isn't obvious in "browser_window/BUILD.gn", which we
will address in a follow-up CL.

Bug: 440107688
Change-Id: Ie85cf81c901fa22826fa8c4ba504f361d4b99790
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6871271
Commit-Queue: Linyu He <linyuh@google.com>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1506569}
7 files changed
tree: 0e7953796c50c284b7cc5748e6fa2245b43495bd
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. clusterfuzz-data
  52. internal
  53. ios_internal
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .cursorignore
  60. .geminiignore
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. SECURITY_OWNERS
  88. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.