commit 547c03a5f89b035d053e541cde5a91cb15b21f6e
author Matt Menke <mmenke@chromium.org> Thu Oct 21 16:37:27 2021
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Oct 21 16:37:27 2021
tree 841e3941937dff0ca2ea097f2b4d7be66ef216ff
parent 21bd9f7e0cd0105e4dadb3fb7f68822cc7d766d5

FLEDGE: Rework browser test fixture slightly.

A number of methods to join interest groups took both a
blink::InterestGroup to join, and separate `ads` and
`trusted_bidding_signals_keys` strings. The methods then ignored the
`ads` and `trusted_bidding_signals_keys` vales in the passed in
InterestGroup in favor of the strings passed in directly. This CL
removes those redundant strings in favor of using the InterestGroup
fields.

This both removes the redundant and somewhat confusingly ignored
absl::nullopt `ads`/`trusted_bidding_signals_keys` values passed in
when creating InterestGroups in tests (soon to be joined by an
ad_components field as well), and makes it easier to make an add use a
custom URL for an interest group ad.

Also remove a redundant JoinInterestGroupAndWaitInJs() method that
takes just an owner and a name, in favor of adding a default parameter
to the JoinInterestGroupAndWaitInJs() method that takes an owner, a name,
and a GURL.

Bug: 1186444
Change-Id: Ic4d6e737d7893a2b254d414b67ac7cd275e1ef2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3235135
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/main@{#933912}