commit | 549dd1d75896ad805c55694077f1c128657ff836 | [log] [tgz] |
---|---|---|
author | Keishi Hattori <keishi@chromium.org> | Mon Jun 06 15:12:45 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jun 06 15:12:45 2022 |
tree | 25b2c791dd23f56b464fe26469889a58612f4efe | |
parent | 9180144922cf8983b5c024090aca09d17083d5cb [diff] |
Reland "Reland "Put Windows compatible handle declarations into separate header"" This is a reland of commit de73498e3047ce45ae3fc18fc453a9c48aa05813 The build failed because windows_types.h was getting included after components/js_injection/browser/web_message_reply_proxy.h but before weblayer/public/js_communication/web_message_reply_proxy.h. Causing PostMessage macro to be applied to only weblayer/public/js_communication/web_message_reply_proxy.h This fixed the issue by renaming the PostMessage to PostWebMessage. Original change's description: > Reland "Put Windows compatible handle declarations into separate header" > > This is a reland of commit b8f4cc4a61a22c3d90a7ca70ee75f40e2df1052f > > Original change's description: > > Put Windows compatible handle declarations into separate header > > > > Put Windows compatible handle declarations into separate header to avoid including the GetClassName macro. > > > > GetClassName is used, for example, as a method name in types_runtime.h so we should minimize where it is included to avoid problems. > > > > Change-Id: Ibc7971c7d8ac66dc1915393142129083d42d7d76 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3607971 > > Reviewed-by: Greg Thompson <grt@chromium.org> > > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > > Commit-Queue: Keishi Hattori <keishi@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#997136} > > Change-Id: I9d953bc0878b9a673e875cc44216b767d5d872bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3615593 > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1007139} Change-Id: I368c31afda30cce084c182eadaafab4a2f0c2263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3666397 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/main@{#1011032}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.