Google Git
Sign in
chromium / chromium / src / 54d95ca9ed4e3c88ecb2969be56f5829f9fef824
commit54d95ca9ed4e3c88ecb2969be56f5829f9fef824[log] [tgz]
authorRakina Zata Amni <rakina@chromium.org>Tue Jul 17 06:15:45 2018
committerCommit Bot <commit-bot@chromium.org>Tue Jul 17 06:15:45 2018
tree893b9d6b0bcda9cd3e527e9d1bb450995e27bdea
parent9f2582c35918a0e55f1fa841e09d61be488cc8d9 [diff]
Make FindInPage be a ContextLifecycleObserver

frame_ in FindInPage might be null when GetWebPluginForFind is called,
causing a crash in crbug.com/848032. This happens when the frame had
detached but the pre-finalizer for FindInPage is not called yet, making
it possible for FindInPage to still receive mojo calls even though
the frame is null. This CL makes FindInPage observe when its document/
execution context is destroyed so that it will close its mojo binding
when that happens.

Bug: 848032
Change-Id: Ifac00128e4efeb98f73fdcb98a944164d9ca1bf1
Reviewed-on: https://chromium-review.googlesource.com/1107032
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575560}
2 files changed
tree: 893b9d6b0bcda9cd3e527e9d1bb450995e27bdea
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .