Google Git
Sign in
chromium / chromium / src / 550c8f6fecf6e877e99b2f5fe502b4cf19c74346
commit550c8f6fecf6e877e99b2f5fe502b4cf19c74346[log] [tgz]
authorMichele Fan <michelefan@chromium.org>Wed Feb 09 22:52:44 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Feb 09 22:52:44 2022
tree4350b5ca67a7449041f7edbf225933e9dd45038c
parent461ad1b0559a872f30c5eeaee2f432659cb71fc0 [diff]
capture_selfie_cam: Hook SetShouldShowPreview() to the callers

This CL adds the logic to hook SetShouldShowPreview() to the callers.
It needs to be set to true when CaptureModeSession is started and
switched to a video recording mode before recording starts.
It needs to be set to false when:
1. Video recording ends;
2. The capture mode session ends without starting any recording;
3. The capture mode session is switched to an image capture mode.

Bug: 1293467
Test: Added a new test
Change-Id: I191fa7c9b6612b395cdf904814f4e48eec8e32f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440911
Reviewed-by: Min Chen <minch@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Michele Fan <michelefan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#969161}
5 files changed
tree: 4350b5ca67a7449041f7edbf225933e9dd45038c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.