commit 552424df40cb3650ae640b72b613c7ea5cc7c3de
author Orin Jaworski <orinj@google.com> Mon Jul 22 19:44:37 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jul 22 19:44:37 2024
tree 53d5aef2e09e60a8cdd749126c5aed4b8fa4ccc2
parent 954886b21811dc5d38c62b3fe870492cfd716051

Change history embeddings search data flow from once to repeating calls

This CL changes the data flow between the HistoryEmbeddingsService and
the front ends. It eliminates the once callbacks that were used to
provide search results before. These were clean and convenient, as
they enabled simple function-style return values with promises on
the front end. But with v2 answers, due to model latency, we will
need early and late callbacks for basic search results and then
search results with answers (potentially more than these two, since
even speculative evaluation has high latency for each result).
So with this change, searches are requested, with no immediate
return value or callback, and then results are published
asynchronously and repeatedly to a specified callback. The change
to the omnibox front end is minimal, but chrome://history now
requires full duplex communication. The browser-initiated calls
are made through its new Page mojom interface.

Bug: 353732707
Change-Id: I78ab49732a38ef58af3209c5d2d87ddb94cf594e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5723174
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: John Lee <johntlee@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1331255}