Debug detached WindowProxy script execution

Per https://crbug.com/435149285 the AndroidReaderModeUseReadability
experiment appears to be causing a CHECK failure [1] in the following
flow:

logging::CheckFailure()
LocalFrame::RequestExecuteScript()
LocalFrameMojoHandler::JavaScriptExecuteRequestInIsolatedWorld()

This is caused by `ToScriptState()` unexpectedly returning nullptr,
which should never be the case when invoked by this mojo method, as the
validity of the mojo invocation should be correctly bound to the
lifetime and validity of the execution context and its ability to
execute script (i.e., being attached, among other things).

This CL captures a lot of scoped crash key information about the frame
in this case, and dumps without crashing instead of actually crashing,
since that information isn't useful.

An earlier version of this CL plumbed a bunch of callsite-specific
information through the mojo call and into the renderer, but this was
discarded as unnecessary when we got clarity on the exact callsite that
was definitely causing the crash. Per [2] and [3] the DOM distiller
component is injecting the "readability triggering" script into an RFHI
whose WindowProxy is apparently in some kind of non-initialized state
that causes ToScriptState() to return null in the mojo handler.

[1]:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/frame/local_frame.cc;l=3206;drc=37e21de1acb8c8061dd13dc41aaa22ea7a1ea992
[2]: https://crbug.com/435149285#comment10
[3]:
https://crash.corp.google.com/browse?q=expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27blink%3A%3ALocalFrame%3A%3ARequestExecuteScript%27+AND+product_name%3D%27Chrome_Android%27+AND+expanded_custom_data.ChromeCrashProto.channel%3D%27beta%27&compProp=expanded_custom_data.ChromeCrashProto.experiments.ids&v2=4b1af6a5-81f8e17d&v1=4b1af6a5-b09b3d6d

R=kevers@chromium.org

Bug: 435149285
Change-Id: I4a148f849753dcea42e2077b50b6b0644a011b23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6861835
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1508381}
1 file changed
tree: 5ee6c6ae140f40e148c02a897a25cb4d3212a5db
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .cursorignore
  54. .geminiignore
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. CRYPTO_OWNERS
  72. DEPS
  73. DIR_METADATA
  74. LICENSE
  75. LICENSE.chromium_os
  76. OWNERS
  77. PRESUBMIT.py
  78. PRESUBMIT_test.py
  79. PRESUBMIT_test_mocks.py
  80. README.md
  81. SECURITY_OWNERS
  82. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.