commit | 55534ca1c83ea4a5ea72afcab4bfca1f5d6624d3 | [log] [tgz] |
---|---|---|
author | Matt Menke <mmenke@chromium.org> | Wed Mar 19 19:22:28 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Mar 19 19:22:28 2025 |
tree | ce48797547daf4a90c7175ce2b5f381247fa4ca7 | |
parent | 9c6115e5c3be79e594942a51b31f465049b14149 [diff] |
[Protected Audience] Wire up devtools auction IDs to KVv2 signals cache. This cl adds devtools instrumentation calls that associate KVv2 trusted signals cache fetches with their corresponding devtools auction IDs. Currently, if a new auction is associated with a fetch after it has been sent over the network, nothing is logged though that may be worth changing in a followup. Other corner cases: * If an auction is cancelled before a fetch starts, but the fetch is still started due to other ongoing auctions, the fetch will still log an event associated with the failed auction. Changing this behavior would require substantial complexity and/or more copies of devtools IDs, so may not be worth it. Devtools consumers are supposed to be robust against such things, anyways. * If an entry from the cache is used directly, without triggering a fetch, nothing is logged to devtools. The fetch events require a network request ID, but the network request may have finished long ago (and in the future, may also have been in another tab). We may want to log some other event in this case, but that's an issue for another day. Bug: 379843989 Change-Id: I322218ee8fd8018b6011b55854f61349802407ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6367483 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: mmenke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/main@{#1435010}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.