commit | 5576e90f34d5a69306b9fc2ecc5a1c1752f13bfc | [log] [tgz] |
---|---|---|
author | Ioana Pandele <ioanap@chromium.org> | Tue Jun 14 08:37:07 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jun 14 08:37:07 2022 |
tree | 63c7940d1bfd2cb5c8c66f52eb902384c3097d0d | |
parent | db6d90eaa2c03d2b5d003bdb1c863db75d19d310 [diff] |
[M103][UPM] Unenroll users from UPM when they receive unresolvable errors. After receiving errors that are not DEVELOPER_ERRORS (which are to be fixed by Chrome) and not PASSPHRASE_REQUIRED errors (which can be fixed by entering the passphrase), users should fall back to the built-in backend and using the legacy Password Settings UI. This CL adds a new boolean pref that is set to true if the user receives an error, which is checked at the following places: 1) Backend selection in PasswordStoreProxyBackend 2) Settings UI (i.e. showing CredentialManager instead of Chrome password settings UI) 3) PasswordManagerSettingService 4) Triggering migrations to Android backend in MigrationDecorator These checks will be used instead of a check for persistent sync auth error, which could be resolved and did not lead to permanent unenrollment from UPM experience. (cherry picked from commit 18dfd9fb414388de0ae1133fbabae759556fdcea) Bug: 1334565 Change-Id: I71c315c4a166cbe942335b7e6154bc0bf1974efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3695236 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Ioana Pandele <ioanap@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1012435} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3702381 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/branch-heads/5060@{#814} Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.