Google Git
Sign in
chromium / chromium / src / 559a04c688919a5f4a13cc195a3524cf68dd63fb
commit559a04c688919a5f4a13cc195a3524cf68dd63fb[log] [tgz]
authorDavid Tseng <dtseng@google.com>Tue Oct 18 18:15:20 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Oct 18 18:15:20 2022
treed41154fdf6c42bf163735404515865e8c440d5de
parentb6727b61a6ccc19bba6a1722df23ad7c140fd027 [diff]
Fixes deserialization errors in AXTree

In
https://chromium-review.googlesource.com/c/chromium/src/+/2572729
the lifetime of the AXTree tied to each of the
RenderFrameHostImpl/RenderFrame backed BlinkAXTreeSource became more
decoupled with the eventual AXTree. That tree lives in the extension
process.

The AutomationEventRouter::DispatchTreeDestroyedEvent does sometimes
arrive before additional tree updates to that "destroyed" tree.

With this change, we more precisely match when RenderFrameHostImpl calls
into AXActionHandlerRegistry::RemoveAXTree.

R=katie@chromium.org

Fixed: 1367575
Test: existing tests including the one added above. Also, manually trigger various crashes (DCHECK's) in AXTree::Unserialize when navigating back/forward quickly without this patch; see that it does not reproduce with it patched.
Change-Id: I7ecccafda52b570d73a276e53fa6b295ff1b6dbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3962275
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1060547}
5 files changed
tree: d41154fdf6c42bf163735404515865e8c440d5de
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.