Reland "Introduce AccountId::Literal for testing convenience" This reverts commit 347f186c5739f6867fad9e0587e6cd63a85af1f8. Reason for revert: with fix window builder. Bug: None Original change's description: > Revert "Introduce AccountId::Literal for testing convenience" > > This reverts commit 114351c44471a7f6ea07ff031cc82befa524063f. > > Reason for revert: broke win builder dbg: https://ci.chromium.org/ui/p/chromium/builders/ci/Win%20Builder%20(dbg)/203954/overview > > ``` > [818/20847] LIB obj/components/account_id/test_support.lib > ..\..\third_party\llvm-build\Release+Asserts\bin\lld-link.exe /lib /OUT:obj/components/account_id/test_support.lib /nologo /WX /ignore:4221 /llvmlibthin @obj/components/account_id/test_support.lib.rsp > warning: no input files, not writing output file > pass /llvmlibempty to write empty .lib file, > pass /ignore:emptyoutput to suppress warning > treating warning as error due to /WX > lld-link: error: lib failed > exit=1 > error: 1 steps failed: exit=1 > ``` > > Original change's description: > > Introduce AccountId::Literal for testing convenience > > > > One of the common mistakes in tests is to define global > > `const AccountId` variable. It conflicts with style guideline, > > and could introduce unexpected behaviors. > > > > This CL introduces AccountId::Literal, which can be used in > > constexpr context, and can be converted into AccountId implicitly > > for easier test writing. > > > > BUG=None > > TEST=Tryjob > > > > Change-Id: I368438deb1a69fd33a293cf91bf6e2643e2a634b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6636616 > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1473081} > > Bug: None > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I8bdc82ce2ca96cfc8fd32e81272e44c7f8e87e15 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6641243 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Elly FJ <ellyjones@chromium.org> > Owners-Override: Elly FJ <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1473102} Bug: None Change-Id: Icc2855e5715b96c5ecc3a73ce5642754e573ba79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6640914 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/main@{#1473268}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.