Google Git
Sign in
chromium / chromium / src / d03e09e0a01416376d95bc1605ade208f9e77375
commitd03e09e0a01416376d95bc1605ade208f9e77375[log] [tgz]
authorAndrew Xu <andrewxu@chromium.org>Wed Feb 13 18:12:47 2019
committerCommit Bot <commit-bot@chromium.org>Wed Feb 13 18:12:47 2019
treeb22c4e494436db5803eaac0f322ba63ebe8349af
parentfd15282add1d1b10eded72509efd33b9395422e9 [diff]
Deal with the edge case of dragging from shelf while typing

The edge case of dragging the shelf while typing in the search
box is not taken into consideration. As result, when the
expected app list view state is FULLSCREEN_SEARCH, its actual
state is FULLSCREEN_ALL_APPS. This CL fixes the problem.

In addition, refactor the code: move the code block, which is for
calculating the app list view state after shelf drag, from
ShelfLayoutManager to AppListView.


Test: None
Bug: 919205
Change-Id: I39aa095bbd1a9417d07b50cc6caed1084fde5f4d
Reviewed-on: https://chromium-review.googlesource.com/c/1462419
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631795}
9 files changed
tree: b22c4e494436db5803eaac0f322ba63ebe8349af
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .