Google Git
Sign in
chromium / chromium / src / 561b553174545fdd2130803e226650029fb21f41
commit561b553174545fdd2130803e226650029fb21f41[log] [tgz]
authorJayson Adams <shrike@chromium.org>Wed Apr 10 00:19:29 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Apr 10 00:19:29 2024
tree4c6e8297eb9e03738e64f74ebc590ebeaa3bbe03
parentd31b91bd7e49cc5aa3d33196a37cba391ef9e14d [diff]
[Mac A11y Sonoma] Reland Activate VoiceOver KVO monitoring later in start-up

The VoiceOver KVO monitoring setup code has a dependency on the
global accessibility state object. This cl ensures the KVO code runs
only after the global a11y object has been created.

This iteration of the cl includes the following changes:

* Ensures KVO notifications other than "voiceOverEnabled" are passed to
  the Application object's superclass (reason for revert).
* Ensures Chrome only acts on "voiceOverEnabled" KVO notifications where
  the global a11y object is the "context" (to avoid swallowing
  notifications destined for other observers).
* Adds a test to ensure the override of observeValueForKeyPath:... in
  BrowserCrApplication always calls super for notifications it
  doesn't match.

Bug: 330759711

Test: out/debug/browser_tests --gtest_filter=ChromeBrowserAppMac*
      out/default/browser_tests \
        --gtest_filter=*PromotionalTabsEnabledPolicy*

Include-Ci-Only-Tests: true
Change-Id: I0ee508a74ab40906fc22273de37f522294d3a1db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5436274
Commit-Queue: Jayson Adams <shrike@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284798}
4 files changed
tree: 4c6e8297eb9e03738e64f74ebc590ebeaa3bbe03
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.