Google Git
Sign in
chromium / chromium / src / 56208c2097b6200029e4e04092e14a9f67f144a0
commit56208c2097b6200029e4e04092e14a9f67f144a0[log] [tgz]
authorTim Sergeant <tsergeant@chromium.org>Sun Sep 12 23:44:52 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sun Sep 12 23:44:52 2021
tree67f8af0e0359faa6c7bccf74120a3c658dd795e0
parent3c12beeb921622d067a39c07ae4505fd3d5b4b91 [diff]
App Service: Don't remove preferred apps for apps with Unknown readiness

AppServiceProxyBase removes preferred app settings for an app whenever
it receives an update with Unknown readiness. However, at this layer of
the code, it is expected that Readiness might be "unknown" even for an
installed app, since Publishers only need to send a delta of changed
fields to update. This causes us to remove preferred apps settings
frequently, including whenever the app is opened.

Thanks to some other issues in the system (crbug.com/1238647), this does
not cause any issues in current production use-cases. However, with
upcoming changes to support link capturing for Web Apps, it became very
easy to overwrite settings in the background.

This CL just checks for Unknown readiness before removing preferred
apps, which resolves the issue.

Bug: 1247554, 1247944
Change-Id: Idaf42bd14644290266bd472929b7a79718ff3f27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3149801
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/main@{#920618}
4 files changed
tree: 67f8af0e0359faa6c7bccf74120a3c658dd795e0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.