commit 564dd224f56a8002300a0983e7df0359ab64d9ee
author Mikel Astiz <mastiz@chromium.org> Mon Feb 05 18:46:26 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Feb 05 18:46:26 2024
tree 314e14e910360d51c62f02d28e23520bbd6a4a66
parent 50383c34e28dd787e578f194571a4af04dc00152

[passwords] Remove PasswordManagerClient::GetSyncState()

No behavioral changes, pure refactoring.

The removed function represented interface-level redundancy as there
is also PasswordManagerClient::GetSyncService(). This redundancy is bad
because it can lead to non-realistic scenarios in tests.

Instead, the one single caller is migrated to invoking
sync_util::GetPasswordSyncState() directly. Theoretically, this may
imply a behavioral change because the old code (before this patch)
could have instantiated SyncService, but this is deemed impossible as
the codepath cannot be exercised early upon profile construction, and
if it did the function would have returned kNotSyncing anyway.

This also means the enum SyncState can be moved to password_sync_util.h.
While doing so, kNotSyncing is renamed to avoid ambiguities when
account passwords are involved. The remaining enum values will be
tackled in follow-up patches.

Finally, if PasswordManagerClient::GetSyncService() is here to stay,
there is no point is having to pass a RepeatingCallback to
SyncCredentialsFilter in order to access SyncService.

Change-Id: Ice19affc3c9af2b6568c5fd15436ad08adeb8351
Bug: b/317058107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5260099
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Victor Vianna <victorvianna@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1256317}