Google Git
Sign in
chromium / chromium / src / 565bac2b35961528f86a2fe4f2755f918051a061
commit565bac2b35961528f86a2fe4f2755f918051a061[log] [tgz]
authorJayson Adams <shrike@chromium.org>Mon May 15 22:56:27 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon May 15 22:56:27 2023
tree2493011f832643554561795be233d6e7bbdafafb
parent9d407321452a47230fa2e5332f88c1c8e31e4b81 [diff]
[Mac Window Minimize] Adjust to macOS 13 window minimize semantics

On macOS13, calling miniaturize: on a window is no longer "atomic"
in that it involves a non-blocking round-trip RPC with the Dock. This
causes problems for code watching for window state changes, when those
checks occur while the application is in an inconsistent state (i.e.
miniaturized: was called but isMiniaturized returns NO).

This cl prevents the round-trip miniaturization from miniaturizing
the window if some operation has effectively canceled it (such as
an orderFront:).

Test: out/Default/interactive_ui_tests \
    --gtest_filter=SessionRestoreInteractiveTest.RestoreMinimizedWindow*

Bug: 1431602
Change-Id: I26333fd484ec6aba0bdba1ba6363c488d2962343
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4429234
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jayson Adams <shrike@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1144432}
2 files changed
tree: 2493011f832643554561795be233d6e7bbdafafb
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.