commit 568f2604719ccd32582561b5d08539fcda8fedfe
author Tommy C. Li <tommycli@chromium.org> Wed Jan 23 21:25:47 2019
committer Commit Bot <commit-bot@chromium.org> Wed Jan 23 21:25:47 2019
tree b87b9c382ec2e1245e6f6f96735abb75c8c75160
parent 9d803dd280d8e02e9849e80469a12fb5eb883931

Omnibox: Steady State Elisions - Stop abusing user_input_in_progress.

Currently, when Steady State Elisions is on, and the user unelides the
URL, we put the full URL into the user text.

This was convenient, but has some unintended consequences. Namely:

 1) user_input_in_progress() as a boolean state becomes confusing, as
    sometimes it means the user has edited the URL, and sometimes it
    means the the user has merely unelided the URL.

 2) Consequently, in many places in the code, we check if user input in
    progress AND if the user has meaningfully edited the URL away from
    the full URL text.

 3) That's not obvious to non-omnibox owners, so it creates bugs like
    the one linked below.

This CL changes how unelision works so it only updates the View's text
and leaves the model's user-text alone. It no longer sets
user_input_in_progress to true for mere unelision.

This allows us to clean up fair number of callsites and puts the nail
in the coffin for the below linked bug too.

Bug: 921777
Change-Id: I9d113649f50c0bfafa1d112002add577e05928f7
Reviewed-on: https://chromium-review.googlesource.com/c/1427244
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625358}