Google Git
Sign in
chromium / chromium / src / 5dc5e7170c1a0c7efc23f3e184bce2a535438337
commit5dc5e7170c1a0c7efc23f3e184bce2a535438337[log] [tgz]
authorPhilipp Weiß <phweiss@chromium.org>Mon Jul 11 10:59:38 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jul 11 10:59:38 2022
tree1bbbc5cfac0c94f831c763ba3a5d0b869caf0020
parent9d34a3beaa616a3c38b7915d12465721415999d2 [diff]
dPWA: Retry once when a custom icon fetch fails

When a web-app is force installed and a custom icon is provided,
the icon fetching fails sometimes according to testers, probably
due to a busy network (many files are fetched when many apps are
installed in short order).

If the custom icon fails for placeholder apps, we don't have a
retry mechanism, at least until the placeholder app is replaced.
To reduce the chance of broken icons, retry failing icon fetches
once, after waiting for 5 seconds.

BUG=b:227338911
TEST=browser_tests --gtest_filter=ExternallyManagedAppManagerImplBrowserTest.PlaceholderInstallSucceedsWithCustomIconAfterRetry

Change-Id: Ie1c6957918a0a2d927f97ea748c73a028cdde993
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3568370
Commit-Queue: Philipp Weiß <phweiss@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1022646}
3 files changed
tree: 1bbbc5cfac0c94f831c763ba3a5d0b869caf0020
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.