Google GitGoogle Git
Sign in
chromium/chromium/src/572d88a002b3b0fcb27dd5c938a09d3c05ea553f
commit
572d88a002b3b0fcb27dd5c938a09d3c05ea553f
[log]
author
Naman Narula <namankumarnarula@gmail.com>
Fri Nov 03 17:15:10 2023
committer
Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
Fri Nov 03 17:15:10 2023
tree
8e0d68137f69b632f767143a538a7c1f4fdba7f4
parent
8953850ddd70c6dcf155c19b95e35a2c6eb0c3ec [diff]
Closing Omnibox popup on click of inactive areas of the BrowserView

Currently, there is an option to close the popup using the Esc key.
However, there is nowhere in the Chrome UI that closes the popup
when clicked. Therefore, the only alternative is to find some
inactive or safe area within the content area.

This change provides an alternative option to close the popup
by clicking on inactive areas of Chrome UI

Fixed: 1380329
Change-Id: Idd650b1eaabacd9946d96eef8f0882d3b85f8502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4902865
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1219541}
7 files changed
tree: 8e0d68137f69b632f767143a538a7c1f4fdba7f4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.