commit | 5803b48232f1e332be7e1a87029c436d247acb10 | [log] [tgz] |
---|---|---|
author | Byungwoo Lee <blee@igalia.com> | Mon Feb 24 04:50:15 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Feb 24 04:50:15 2025 |
tree | 698f47568c19a93362e257a9838a96cf5286c9e3 | |
parent | 2640e46c83af964f79a9cf53a4096c5869cb8406 [diff] |
Reland "Fix build with safe_browsing_mode=0 (4/5)" This is a reland of commit 8f68ae0dc09483d11056235dd23538a9c1716adb Original change's description: > Fix build with safe_browsing_mode=0 (4/5) > > Fix the `safe_browsing_mode=0` build by guarding header includes > and related codes using `BUILDFLAG(SAFE_BROWSING_AVAILABLE)`. > > This CL is a part of the build fix that removes following source > files or build dependency from build target: > - //chrome/browser:browser > - component_updater/file_type_policies_component_installer.cc > - component_updater/file_type_policies_component_installer.h > - //components/safe_browsing/content/browser:client_side_detection > - //chrome/browser/enterprise/data_controls:enterprise_data_controls > - reporting_service.cc > - reporting_service.h > - //chrome/browser/extensions:extensions > - api/safe_browsing_private/ > - safe_browsing_private_event_router.cc > - safe_browsing_private_event_router.h > - safe_browsing_private_event_router_factory.cc > - safe_browsing_private_event_router_factory.h > - //chrome/browser/safe_browsing:safe_browsing > - chrome_safe_browsing_tab_observer_delegate.cc > - chrome_safe_browsing_tab_observer_delegate.h > - //components/safe_browsing/content/browser:client_side_detection > - //chrome/browser/permissions:permissions > - contextual_notification_permission_ui_selector.cc > - contextual_notification_permission_ui_selector.h > - //chrome/browser/ui:ui > - //components/safe_browsing/content/browser:client_side_detection > - //chrome/browser/ui/webui:configs > - //chrome/browser/ui/webui/safe_browsing > - //chrome/test:browser_test > - //components/safe_browsing/content/browser:client_side_detection > - //chrome/test:unit_tests > - //components/safe_browsing/content/browser:client_side_detection > - //components/safe_browsing/core/browser/db:v4_store > - v4_store.cc > - v4_store.h > > and guards following header inclusions under the flag: > - chrome/browser/enterprise/data_controls/reporting_service.h > - chrome/browser/extensions/api/safe_browsing_private/ > - safe_browsing_private_event_router_factory.h > - chrome/browser/safe_browsing > - chrome_safe_browsing_tab_observer_delegate.h > - chrome/browser/permissions/ > - contextual_notification_permission_ui_selector.h > - chrome/browser/ui/webui/safe_browsing/chrome_safe_browsing_ui.h > - components/safe_browsing/ > - content/browser/safe_browsing_tab_observer.h > > This CL also removes unnecessary guard in safe_browsing_tab_observer.cc > > Bug: 390205854 > Change-Id: Ic9047c55fd0e29d8e09242dd0135a3f8dccc1666 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6174774 > Reviewed-by: Elias Klim <elklm@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Matt Mueller <mattm@chromium.org> > Commit-Queue: Byungwoo Lee <blee@igalia.com> > Reviewed-by: Dana Fried <dfried@chromium.org> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org> > Reviewed-by: Lily Chen <chlily@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1420836} Bug: 390205854 Change-Id: I0cf54eb6535ac58761ad7e45976d054eb1101d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6275265 Reviewed-by: Elias Klim <elklm@chromium.org> Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by: Lily Chen <chlily@chromium.org> Reviewed-by: Nathan Parker <nparker@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Matt Mueller <mattm@chromium.org> Reviewed-by: Dana Fried <dfried@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Commit-Queue: Byungwoo Lee <blee@igalia.com> Cr-Commit-Position: refs/heads/main@{#1423763}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.