Google Git
Sign in
chromium / chromium / src / 5835457d91615d2d6cc582f3bda054c1f506ef49
commit5835457d91615d2d6cc582f3bda054c1f506ef49[log] [tgz]
authorhenrika <henrika@google.com>Thu Apr 24 11:13:51 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Apr 24 11:13:51 2025
tree5c9f37593dd9c185b44de9aed5dd2b16062977dc
parentced78e5373e0883fdb21ab9a098a79d8d71b0b60 [diff]
Adds DEEP_NOISE_SUPPRESSION to supported system effects

Note that the internal system effect is called Deep Noise Suppression
but the feature in the Windows UI is called Voice Focus. It is a new
feature in Windows 24H2 and it removes noise sources in combination with
voice/communication input streams.

The change will not lead to any functional changes, i.e., no new system
effects are enabled or disabled. We only extend the enumeration support
to make it more clear that the Deep Noise Suppression effect is also
enabled in combination with the other (AEC, NS and AGC) when supported.

This CL does the following:

* Adds DEEP_NOISE_DEEP_NOISE_SUPPRESSION to the effect mask seen in chrome://media-internals if the device supports DNS and the user has not explicitly disabled the Voice Focus (DNS) feature in the system UI on Windows.
* Adds one more value to Media.Audio.Capture.Win.VoiceProcessingEffects

As a result, chrome://media-internals can now show:

ECHO_CANCELLER | NOISE_SUPPRESSION | AUTOMATIC_GAIN_CONTROL |
DEEP_NOISE_SUPPRESSION

and if the user disables Voice Focus in their system UI:

ECHO_CANCELLER | NOISE_SUPPRESSION | AUTOMATIC_GAIN_CONTROL

Bug: 399308033
Change-Id: I8dfd10ac6bcf26b72a691372901c0339f0c5be55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6438838
Commit-Queue: Henrik Andreasson <henrika@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1451038}
5 files changed
tree: 5c9f37593dd9c185b44de9aed5dd2b16062977dc
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.