| commit | e98bb9d7aa1a80891c93d04e4c7214cd71ca91e4 | [log] [tgz] |
|---|---|---|
| author | Daniel Rubery <drubery@chromium.org> | Tue Oct 26 03:48:59 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Oct 26 03:48:59 2021 |
| tree | 2176761f4d9999267d8c06e5c87c2d2c98632a0c | |
| parent | ab9bd9c43d9b81ec94f423aea93a26691b24b00e [diff] |
Remove DCHECK in V4Store destructor This is expected to run on the IO thread, since it should be called via SafeBrowsingDatabaseManager::StopOnIOThread. If the task to do so is skipped on shutdown however, we may end up running the destructor off the IO thread, which is harmless. The alternative here is to make the destruction of the V4Store object block shutdown, which seems like a worse solution. Fixed: 830633 Change-Id: I2b795fd7d70f9846ac7772ad530b7a773a0f9a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3242725 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/main@{#934818}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.