Google Git
Sign in
chromium / chromium / src / 586af386595943856c00e3d78f720dfa3d82d53a
commit586af386595943856c00e3d78f720dfa3d82d53a[log] [tgz]
authorSunny Sachanandani <sunnyps@chromium.org>Tue Jul 24 21:44:38 2018
committerCommit Bot <commit-bot@chromium.org>Tue Jul 24 21:44:38 2018
tree98be3a2a4fe35eb27e1663e3ffe57aa63206e009
parentb9d9251e5823107903c09909cfb47dd3078f02c1 [diff]
Do not call IsActiveTree() in LayerTreeImpl destructor

IsActiveTree() indirectly calls active_tree_.get() in LayerTreeHostImpl.
Since std::unique_ptr::reset() nulls out its ptr before deleting the
owned object, IsActiveTree() will always be false, and the swap promises
will always be broken with ACTIVATION_FAILS. This causes
LayerTreeHostTestSwapPromiseDuringCommit to fail when the wait for main
frame or commit condition is removed from LayerTreeTest::EndTest().

R=danakj
BUG=703263

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3819f76ab8f576c80faccf8db3ecd7ddb9b5954d
Reviewed-on: https://chromium-review.googlesource.com/1145920
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577696}
1 file changed
tree: 98be3a2a4fe35eb27e1663e3ffe57aa63206e009
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .