commit | 587e8887c00e63af024acee86d1b53cb494de10f | [log] [tgz] |
---|---|---|
author | Mohamed Amir Yosef <mamir@chromium.org> | Fri Mar 21 19:17:53 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Mar 21 19:17:53 2025 |
tree | 814de9eb97955674e1e4d12a9191560b4d2aecd6 | |
parent | 18a8b1c914126e23fca07cc62d2cef8aaa63bc54 [diff] |
[DC] Read protocol from wallet response on Android Wallets have changed their response format to match the expected format of Web DC API [1]. And while doing that, the new format is packaged differently in the response Intent. Ideally, Jetpack libraries will allow reading the formats easily, but since adding the Jetpack dependency increased the binary size beyond the the acceptable threshold, we had to fork the relevant pieces for Jetpack to parse the old and modern response formats. This is CL favors the modern response packaging if it is available, and will read the protocol from it whenever it's returned. Otherwise, it will fallback to the legacy format. As additional context: GMSCore is post-processing the format such that if only legacy format is returned from the wallet, it packages it in addition to the modern format. This is to support Chrome version that understand only legacy format, and break the gap with wallet that send only the legacy format. After the web API as well as the Android API are launched, all backward compatibility should be removed since it will be the expectations of apps and wallets to adhere to the latest specs. [1] https://wicg.github.io/digital-credentials/#the-digitalcredential-interface Bug: 336329411 Change-Id: I301434456bf9ae83ad51538f033d92cbc21fbf44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6287374 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/main@{#1436223}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.