commit 58eb4d3acfd529e07444e79c6f6c77703077d38c
author Colin Kincaid <ckincaid@chromium.org> Fri Mar 10 18:30:53 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Mar 10 18:30:53 2023
tree 1f20144c4c0b84b2837f94d0c2435107526373ac
parent 8cadf2fa52f810d6f898951a3c4d2b4fb55a3f91

Revert "crOS: Remove OAuth2LoginVerifier"

This reverts commit 2f70b4c7b3118db8c964f32e610f24305e24554b.

Reason for revert: Broke login.ChangePassword tast test according to bisector.

Bug: b/272558325

Original change's description:
> crOS: Remove OAuth2LoginVerifier
>
> ChromeOS has a dedicated legacy class for minting cookies that
> essentially duplicates the work of `AccountReconcilor`. Since ChromeOS
> Account Manager was launched, this is no longer needed.
>
> Remove `OAuth2LoginVerifier` and make `OAuth2LoginManager` observe
> `AccountReconcilor` instead of attempting /MergeSession itself.
>
> This CL is essentially a reland of https://crrev.com/c/1674099. That CL
> had to be reverted because `AccountReconcilor`'s error callbacks were
> not deterministic. https://crrev.com/c/3998935 made
> `AccountReconcilor`'s error callbacks deterministic since M109.
>
> DD: http://doc/1fACI5GQgXvmlmEJj6aPedazXeDZAZPw9jH_E91WGe3w
>
> Test Plan:
>
> Automated tests:
>
> - browser_tests --gtest_filter="*OAuth2Test*"
> - browser_tests --gtest_filter="*MergeSessionTest*"
> - Tast tests
>
> Manual tests:
>
> Permutations of the following test matrix:
>
> - Existing / new users
> - 1 / 2 accounts in Account Manager
> - Device / Secondary Account in error
>
> Fixed: b/260076740
> Test: See above
> Change-Id: I317ec1de1f06c7d1f0a3e225309536463fefb879
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4306643
> Reviewed-by: Anastasiia N <anastasiian@chromium.org>
> Commit-Queue: Kush Sinha <sinhak@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1114614}

Change-Id: Id2e1e5c0adcdf01495f817d8d5dfe99b4162d6a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4327900
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Owners-Override: Colin Kincaid <ckincaid@chromium.org>
Commit-Queue: Colin Kincaid <ckincaid@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1115813}