Google Git
Sign in
chromium / chromium / src / 5925010e5bf81a52634f1e01a84fbf4e7629ba44
commit5925010e5bf81a52634f1e01a84fbf4e7629ba44[log] [tgz]
authorzhoupeng <zhoupeng.1996@bytedance.com>Tue Nov 12 05:19:17 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Nov 12 05:19:17 2024
treea69aa8041bd84b2554192e297554dd52f3e7c869
parent50a6392dc27fba90654a950fef72bfd5724a3af6 [diff]
The `validity.customError` should return true if the object element has a custom error

According to specifications [1]:
- The `setCustomValidity(error)` method steps are:
-   1. Set error to the result of normalizing newlines given error.
-   2. Set the custom validity error message to error.
- `element.validity.customError`:
-   Returns true if the element has a custom error; false otherwise.
When the object element uses `setCustomValidity` to set a custom
error, the element's `validity.customError` should be set to true.
`HTMLObjectElement` does not need to override related functions.

[1]:
https://html.spec.whatwg.org/multipage/#dom-validitystate-customerror

Bug: 40781343
Change-Id: I99500d2ffed863ba9ed7c760c36ca6d0c08c6978
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999040
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Peng Zhou <zhoupeng.1996@bytedance.com>
Cr-Commit-Position: refs/heads/main@{#1381597}
3 files changed
tree: a69aa8041bd84b2554192e297554dd52f3e7c869
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.