Google Git
Sign in
chromium / chromium / src / 5930a9fd1795c718f1aaa625029bd89a8eb1efe4
commit5930a9fd1795c718f1aaa625029bd89a8eb1efe4[log] [tgz]
authorNick Diego Yamane <nickdiego@igalia.com>Fri May 29 17:22:34 2020
committerCommit Bot <commit-bot@chromium.org>Fri May 29 17:22:34 2020
treed22530cea47980679234da3c8fe3a389df0e24d7
parent997220858334c0e8cad0c1e299586c0db367ed88 [diff]
ozone/wayland: Fix data objects initialization and ownership

DataDevice-related wrappers initialization and ownership, for both
standard and GTK's primary selection, are quite confusing and spread
over different parts of the backend code. This CL fixes and simplifies
it by:

- Moving {WaylandData,GtkPrimarySelection}Device ownership to their
respective DataManager wrapper class. E.g: WaylandDataDeviceManager owns
WaylandDataDevice singleton;

- Fix WaylandClipboard initialization whether the compositor happens to
advertise GtkPrimarySelectionDeviceManager after wl_seat and
wl_data_device_manager;

- Use dependency injection to provide DataSources with the correct
DataDevice instance at their construction time;

- Clean up WaylandConnection by getting rid of the multiple (and almost
unused) data device getters from it as well as removing unneeded header
includes.

Bug: 896640
Change-Id: Ie12964fdf4e7b78bbbd9a11e133ab082613f1c7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216320
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#773235}
16 files changed
tree: d22530cea47980679234da3c8fe3a389df0e24d7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.