commit 596072c1056b095adbd8060f44690e446a3c7d8d
author Anna Tsvirchkova <atsvirchkova@google.com> Fri Aug 18 10:16:23 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Aug 18 10:16:23 2023
tree fe03c8f2e0894a7ce5d602ecefd99c39bdbe0786
parent aaf082ecef117ef6befce5db1d8d86318cfe01cb

[TTF] Move password generation call under AutofillAgent::ShowSuggestions

Currently the password generation is triggered in
PasswordGenerationAgent::HandleFocusChangeComplete(), which is triggered
in AutofillAgent::HandleFocusChangeComplete().
The password suggestions are triggered in
PasswordAutofillAgent::ShowSuggestions, which is triggered in
AutofillAgent::ShowSuggestions.

Moving the call PasswordGenerationAgent::HandleFocusChangeComplete()
also under AutofillAgent::ShowSuggestions would make the flow of the
code more straightforward, because all the possible autofilling option
calls would be placed in one method in the order from most specific to
the least specific:
 - Try to call password generation. Return early if it worked.
 - Try to call password suggestions. Return early if it worked.
 - Call other autofill suggestions.

Password generation will not be triggered by JS any more (as now it's
triggered from the method, which is called only when there is a user
gesture).

Bug: 1469829
Change-Id: Ifed8b35a8eee10d2baf3dfd1f2c6288f690116cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4761404
Reviewed-by: Florian Leimgruber <fleimgruber@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Anna Tsvirchkova <atsvirchkova@google.com>
Cr-Commit-Position: refs/heads/main@{#1185109}