Google Git
Sign in
chromium / chromium / src / 59ae24babb60c0a2a662b57630a276a9d83761aa
commit59ae24babb60c0a2a662b57630a276a9d83761aa[log] [tgz]
authorEdman Anjos <edmanp@google.com>Fri Dec 01 15:15:03 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Dec 01 15:15:03 2023
tree7168d9c77917ea7101cf1c01a1da8e13b5e74c82
parent12169c2f5514235fa76bba57e048f9bbb0854012 [diff]
CRD: Alert screen reader users when the security curtain is visible

Add `role="alert"` attributes to curtain_screen.html so that the screen
reader will notify users about it.

Previously the curtain would mute audio output immediately. We must now
delay it when the screen reader is enabled so the reader has time to
read the alert before we mute audio output. This is done by waiting for
20 seconds when the reader is enabled.

The 20 seconds time was chosen as twice the time it takes the screen
reader to read the alert with the default English voice.

This also updates the curtain InitParams so that callers can configure
how long the curtain should wait when muting audio output.

  ash/curtain/security_curtain_controller_impl_unittest.cc \
  remoting/host

Bug: b:268174926
Test: enable ChromeVox, start CRD from DPanel, it reads the security curtain contents
Test: repeat previous test with --enable-features=EnableCrdAdminRemoteAccessV2,CrosPrivacyHubV0
Test: testing/xvfb.py tools/autotest.py -C out_/Default --run-all \
Change-Id: I290a10a504dfec51ae75b5a032923dc079dafb65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5040714
Reviewed-by: Dominic Battre <battre@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Edman Anjos <edman@chromium.org>
Reviewed-by: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/main@{#1231927}
12 files changed
tree: 7168d9c77917ea7101cf1c01a1da8e13b5e74c82
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.