commit | 59d1b17b82f99cac8e00ea75627a16c67ce52136 | [log] [tgz] |
---|---|---|
author | Arthur Sonzogni <arthursonzogni@chromium.org> | Mon Feb 05 22:05:35 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Feb 05 22:05:35 2024 |
tree | 0b05480009fed8020a617092edf566f13627dc28 | |
parent | dfd27912050e76da529cfe391a6c1056ca037021 [diff] |
PA: Fix transitive include of //build/build_config.h I am investigating why the CQ is blocking: https://chromium-review.googlesource.com/c/chromium/src/+/5205331?checksRunsSelected=linux-rel&tab=checks Apparently, some bots on Linux become much slower, causing global timeout. The patch is a no-op. So I am supposing this is caused by some missing //build/build_config.h that used to be transitively included, but aren't after reordering some headers.o Note: In practise this wasn't the issue. It is still worth fixing. Script: ------- ``` tokens=$(cat build/build_config.h | sed -n "s/#define \([^\ ()]*\) /\1 /p" | cut -f1 -d\ ) for file in $(find base/allocator/partition_allocator/src/partition_alloc -name "*.h" -o -name "*.cc") do include_line=$(grep -n "build/build_config.h" "$file" | head -1 |cut -f1 -d:) for token in $tokens do token_line=$(grep -n "$token" "$file" | head -1 | cut -f1 -d:) if [[ "$token_line" == "" ]] then continue fi if [[ "$include_line" == "" ]] then echo "$file" -- "$token" -- " Missing include" continue fi if [ "$include_line" -gt "$token_line" ] then echo "$file" -- "$token" -- " Token used before include: $include_line vs $token_line" fi done done | sort | uniq -c | sort -rn ``` Output: ------- ``` 2 base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/memory/ref_counted.cc -- ARCH_CPU_X86_FAMILY -- Missing include 1 base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/memory/ref_counted.cc -- ARCH_CPU_X86 -- Missing include 1 base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/ios/ios_util.h -- OS_IOS -- Missing include 1 base/allocator/partition_allocator/src/partition_alloc/page_allocator_internals_posix.cc -- ARCH_CPU_ARM64 -- Missing include ``` Bug: 1508847 Change-Id: I0b409fcb3baf08eedc54c86adad2eeb5f2c2dba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5269103 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/main@{#1256439}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.