commit | 5a164cc70cfda7e6229b9b03b15ba09422660375 | [log] [tgz] |
---|---|---|
author | Timofey Chudakov <tchudakov@google.com> | Thu Sep 21 10:58:35 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Sep 21 10:58:35 2023 |
tree | 55ba2f73b5cf672d7842cbf15b27a054eaa51d97 | |
parent | 853fc0d246428b186c5bc81e70d9068fb75c4e73 [diff] |
[mullet m2] Run callbacks when editor dialog is closed. This CL is a scaffolding for later changes which make address editor re-open AutofillPopup upon editor dismissal. This is only possible to do once the source window receives the focus back. When the user clicks one of the dialog's buttons, the corresponding callback is invoked. Then the focus is returned back to the web contents. The Autofill popup can only be opened in a focused web contents, so we have to start opening the popup after the focus has been transferred back to the previously focused form field. This can be achieved by running the dialog callbacks when the dialog window is being closed. Instead of running the dialog callbacks when the dialog window is being closed, another on_window_closed callback could've been introduced. This would increase the total number of editor callbacks to 3. In reality, editor needs only 1 callback, which accepts the user decision and the modified autofill profile. This will be implemented in the subsequent CL. Bug: 1459990 Change-Id: I99e13483ff061d1442a5ed980295dbad2117a0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4847411 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Timofey Chudakov <tchudakov@google.com> Reviewed-by: Bruno Braga <brunobraga@google.com> Cr-Commit-Position: refs/heads/main@{#1199518}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.