Google Git
Sign in
chromium / chromium / src / 5aa846a2801bd507e31e5c267076b509e1b58154
commit5aa846a2801bd507e31e5c267076b509e1b58154[log] [tgz]
authordpapad <dpapad@chromium.org>Fri Nov 15 00:35:56 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Nov 15 00:35:56 2024
tree10a57734a2eee822d3e4def7e8390b5a1393f842
parentcaa7af57f310d16c29ae9bcee96cf217a701b011 [diff]
NewTabPage: Stop passing js files in build_webui() static_files.

This was incorrect in a few ways:
 1) It bypassed the checks in tools/typescript/validate_tsconfig.py
    about whether JS files are allowed in a given folder, since
    static_files are not passed through the TS compiler.
 2) It resulted in resources that should only be registered in
    chrome-untrusted://new-tab-page/ to erroneously also be registered
    in chrome://new-tab-page/. For example [1] should not exist, only
    [2] should.

Fixed by introducing a separate grd file for the untrusted resources,
which also prepares the ground for migrating these JS files to TS in a
follow-up, where a dedicated build_webui() target will be added.

[1] chrome://new-tab-page/untrusted/background_image.js
[2] chrome-untrusted://new-tab-page/background_image.js

Bug: 379076355
Change-Id: Ie67324adae177945a6bd6f40e1332a89e207e050
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6022066
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Riley Tatum <rtatum@google.com>
Cr-Commit-Position: refs/heads/main@{#1383348}
6 files changed
tree: 10a57734a2eee822d3e4def7e8390b5a1393f842
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.