Add test confirming PageState base urls aren't empty. ExplodedFrameState::initiator_base_url_string is absl::optional, when the feature is off, and should never be empty when it's enabled, so there's no need to store empty GURLs in session state. This CL 1) adds a comment in RecursivelyGenerateFrameState() to clarify that we're not storing an empty GURL, and 2) adds a test to confirm that we don't save PageState with an empty GURL in place of a nullopt. Bug: 1356658 Change-Id: Idf8ee754dd51985f0a25ece6eb480b0ee71b9463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4455088 Reviewed-by: Charlie Reis <creis@chromium.org> Commit-Queue: James Maclean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/main@{#1150738}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.