Google Git
Sign in
chromium / chromium / src / 5b26ca28d53890681a6d98dc521929f0fc1e7543
commit5b26ca28d53890681a6d98dc521929f0fc1e7543[log] [tgz]
authorJoanmarie Diggs <jdiggs@igalia.com>Tue Jan 23 23:09:33 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jan 23 23:09:33 2024
tree37d1dd3ca13dca54cd06ee5ef101e1fdf5c9e111
parent6016cf1857e99a1cb4eefe530e0270e970b0c662 [diff]
[A11y] Adjust fix for "De-flake AccessibilityContenteditableDocsLi"

crrev.com/c/5180532 fixed a flake that was caused by previousOnLineId
being unexpectedly null. The fix was to find the highest LayoutInline
ancestor of a newly-attached text node and mark that inline object
dirty so that previousOnlineId values would be recalculated.

This fix introduced a performance regression in two tests where many
text nodes were during the test. Given that the flake being fixed seems
to be limited to a whitepsace-only node, attempt to improve performance
while preserving the fix by only marking the subtree dirty when a
whitespace-only node is attached.

Bug: 1367886, 1520217
Change-Id: I2a227e360a48d2d7acbeee3a4037a7715ef583a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5224647
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1251117}
1 file changed
tree: 37d1dd3ca13dca54cd06ee5ef101e1fdf5c9e111
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.