commit 5b45ba982c9d34c5eb82a3ad55fce4b5026bd26c
author Jayson Adams <shrike@chromium.org> Mon Sep 09 23:29:03 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Sep 09 23:29:03 2024
tree c025e5b0404891ff5cee95c27402ca2dc0347fc9
parent f247f08c680f39662ae51ad4370e38f7b719ba35

[network cors urlloader] Avoid cloning DevTools connection all the time

CorsURLLoaderFactory::CreateLoaderAndStart() will sometimes clone
the DevTools connection even if a resource request has no devtools
request id. When this happens, the network process spends extra CPU
cycles creating a connection that's not needed and never used. This
cl adds a check for a request id before proceeding with cloning the
connection.

Disabling this cloning regresses diagnostics available through Audits,
as some audit error messages may only appear if the page is loaded with
the DevTools front-end already attached. This also breaks some tests
that checked for the production of these audits without the Network
domain being enabled. Historically, signals were dispatched through
NetworkServiceClient without requiring cloning. With the introduction
of DevToolsObserver, unconditional cloning was required to support the
old semantics. The DevTools team ultimately OKed this change, and the
removal of the breaking tests.

Bug: 331729360
Change-Id: I5731757f24596e191334b76dbdff894cef9c46e0
Include-Ci-Only-Tests: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5404918
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Jayson Adams <shrike@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1353055}