Google Git
Sign in
chromium / chromium / src / 5b672ce7088999b3d9b09267082a613849e208d5
commit5b672ce7088999b3d9b09267082a613849e208d5[log] [tgz]
authorJavier Fernández García-Boente <jfernandez@igalia.com>Tue Jan 09 14:41:33 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jan 09 14:41:33 2024
treeb22c2e8ed0695d81fe0bd61bac93e99495ee98cf
parente21fde5c05e394c90de6288eda3f2f0edbaf83b3 [diff]
Correctly handle a zero value for X25519 deriveBits' length parameter

The Secure Curves spec draft states that we should trunk the derived
bits based on any non-null value passed in the length parameter. Our
currently implementation has been considering zero like null, so we
are returning the entire derived bits array.

The bug 1433707 mentions on ongoing discussion related to the lack of
interoperability on the handling of the deriveBits' length parameter
in several algorithms, being the X25519 one of them. The proposed
change in the spec could be backward-incompatible, so we need time to
evaluate the impact on Chrome's implementation.

While the mentioned spec change discussion continues, this CL fixes a bug in our implementation that considered zero as null. With this change zero will return an empty vector, which matches the current spec.

Bug: 1433707
Change-Id: Ifbf5829db04bbc7c9ff916d27b586feae345b536
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5013612
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Elly FJ <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1244653}
7 files changed
tree: b22c2e8ed0695d81fe0bd61bac93e99495ee98cf
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.