Google Git
Sign in
chromium / chromium / src / 5b75b4a495da5af11b4f5d1ed447acf08b7c8e05
commit5b75b4a495da5af11b4f5d1ed447acf08b7c8e05[log] [tgz]
authorMohsen Izadi <mohsen@chromium.org>Wed Nov 23 20:38:26 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Nov 23 20:38:26 2022
tree6bea758a9cb0e9257feb370cbdacb187c7e6cc4e
parent27d0a4760339fddd5eaf37da4cdc5f0bd2dc89fb [diff]
Fix presentation callbacks in PresentationTimeRecorder

`PresentationTimeRecorder` uses presentation callbacks to determine when
a frame is presented on the screen. This class is mainly used to measure
latency of different UI interactions in ChromeOS and report them as UMA
histograms. Currently, the callbacks used in this class will be called
even if the next submitted frame fails to successfully present on the
screen. This CL fixes this by using callbacks that would be called when
a subsequent frame successfully gets on the screen.

Bug: 1378612
Change-Id: Ib76134905cbefa7d4ebf52d4a98c28bab25598f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4037545
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1075305}
3 files changed
tree: 6bea758a9cb0e9257feb370cbdacb187c7e6cc4e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.