Google Git
Sign in
chromium / chromium / src / 5bf3c605eda879c22613541596f31f32d753103a
commit5bf3c605eda879c22613541596f31f32d753103a[log] [tgz]
authorPavol Marko <pmarko@google.com>Mon Apr 08 20:50:54 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Apr 08 20:50:54 2024
treef1082353e1f1707dac3aec11801189409d555a20
parentf746c0ecc29d5652a39d9106374da10595dbcd52 [diff]
Fix memory leak and clean up outdated comments

browsertest runs in CL:5425011 uncovered a memory leak -
DialogEnrollmentDelegate instances are never destroyed. They are
actually not used for anything since at least
https://codereview.chromium.org/24792004, so replace the class with a
non-member function.

While we're here, remove refrences to http://crosbug.com/30422 which got
migrated to https://g-issues.chromium.org/issues/40804489 which has been
marked fixed in 2013.

Note: Tests for this are added in follow-up CL CL:5425011 .

Bug: none
Test: Added in CL:5425011 which fixes the actual behavior.
Change-Id: Ic4c768191c1fada49dddd10b334dad40fa849bfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5434555
Reviewed-by: Andreea Costinas <acostinas@google.com>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Oleksandr Sarapulov <olsa@google.com>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284089}
1 file changed
tree: f1082353e1f1707dac3aec11801189409d555a20
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.