media: Fix InterfaceFactoryImpl renderer disconnection handling

The buildflag guards used for handling `renderer_receivers_`
disconnection errors are different from those for `renderer_receivers_`
declaration.

When using MojoRendererService for clear playback, during tear down,
InterfaceFactoryImpl gets disconnected first. If there's still
MojoRendererService there, it should not be destructed, to prevent
this disconnection error. But due to the bug, IsEmpty() returns true
and InterfaceFactoryImpl is destructed, which then will destruct
MediaFoundationRenderer.

This can also happen when we have both a MojoRendererService and
MojoCdmService. This should be pretty rare since in WebMediaPlayerImpl
holds a reference to the CDM. So this should only happen when the
disconnection handling of the CDM and the media Renderer gets out
of order. So when the CDM is destroyed, it'll trigger the
OnReceiverDisconnect(), which will check IsEmpty(), which will
return true due to this mismatch, even though the Renderer is still
connected. This will cause the destroy callback be invoked and
InterfaceFactoryImpl destroyed, which will destroy the
MediaFoundationRenderer prematurely, causing a disconnection error in
MediaFoundationRendererClient.

Note that when MojoCdmService is destroyed, the underlying
MediaFoundationCdm will not be destroyed immediately since
MojoRendererService still holds a ref-count to it. It'll only
be destroyed after MediaFoundationRenderer is destroyed, to prevent
playback error caused during the tear down process.

Bug: 1376166
Test: Manually tested and the problem doesn't repro anymore.
Change-Id: I7f3c1860c5f4b1d7ce2914ead51c1931d1d583bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3964850
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Frank Li <frankli@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1060769}
1 file changed
tree: 1f225cd0c006a33bd66cabe16478217b7d917eb2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.