[scroll-animations] Run style/layout twice if necessary This CL solves the "first frame problem" [1], where ScrollTimelines created by style recalc end up as inactive, because layout hasn't run yet at the time that style recalc takes place. When a new timeline is created, it goes into a list of "unvalidated" timelines. During the lifecycle update, right after the style and layout steps, we go through all such timelines and check if the current timeline state (snapshot) is "stale" compared to a freshly computed snapshot. If it is, it means that layout had some effect on the timeline(s) that we would like to include in the next frame. We then mark the associated effect targets for style recalc, which in turn triggers a re-run of the style/layout steps in the lifecycle. After all timelines have been validated, the list of unvalidated timelines is cleared. This guarantees that we don't accidentally trigger style/layout more than twice. [1] https://github.com/w3c/csswg-drafts/issues/5261 Fixed: 1145933 Bug: 1074052 Change-Id: Ic915bb71b204c93cbde1c5f485d26a4b1c2bd09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517448 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Stefan Zager <szager@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#829624}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.