[scroll-animations] Run style/layout twice if necessary

This CL solves the "first frame problem" [1], where ScrollTimelines
created by style recalc end up as inactive, because layout hasn't
run yet at the time that style recalc takes place.

When a new timeline is created, it goes into a list of "unvalidated"
timelines. During the lifecycle update, right after the style and
layout steps, we go through all such timelines and check if the current
timeline state (snapshot) is "stale" compared to a freshly computed
snapshot. If it is, it means that layout had some effect on the
timeline(s) that we would like to include in the next frame. We then
mark the associated effect targets for style recalc, which in turn
triggers a re-run of the style/layout steps in the lifecycle.

After all timelines have been validated, the list of unvalidated
timelines is cleared. This guarantees that we don't accidentally
trigger style/layout more than twice.

[1] https://github.com/w3c/csswg-drafts/issues/5261

Fixed: 1145933
Bug: 1074052
Change-Id: Ic915bb71b204c93cbde1c5f485d26a4b1c2bd09f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517448
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829624}
8 files changed
tree: 0f1438aae717c54d11a56ebd1ede6020534aac2e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.