[M144] Update zoom page action properties before bubble visibility Original change's description: > Update zoom page action properties before bubble visibility > > Extract the logic for updating the zoom page action's accessible name, > tooltip, and image into a separate method, > `UpdatePageActionIconProperties`. This new method is invoked prior to > `UpdateBubbleVisibility`. The logic to show or hide the page action icon > remains in `UpdatePageActionIcon` and is executed afterwards. > > Root cause: > In the current flow, showing / refreshing the zoom bubble can synchronously trigger reads of the anchor’s accessible name / tooltip (and may also trigger an A11y announcement) as part of the bubble update. If we update the page action properties after calling Show() / RefreshIfShowing(), then: > > the bubble refresh path can pull the old accessible name/tooltip (X%) during its construction/refresh, and/or > > an A11y event/announcement can fire immediately using whatever name is set at that instant (still X%), > > and only after that we override the accessible name/tooltip to Y%. At that point it’s “fresh” for subsequent reads, but the announcement/UI work already happened. > > Fix: > This sequence guarantees that the zoom page action icon reflects the > updated zoom percentage and correct icon state before the zoom bubble is > updated or shown. > > Recording: https://screencast.googleplex.com/cast/NjI3MzEzNTYzOTc4OTU2OHwzZDhmM2Y1NC0yMA > > Bug: 481634944 > Change-Id: Ice8eb4c12e902d63aa3efae9fc900cb08c217da4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7573545 > Reviewed-by: Kaan Alsan <alsan@chromium.org> > Commit-Queue: Daniel Soromou <koretadaniel@chromium.org> > Reviewed-by: Darryl James <dljames@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1584825} (cherry picked from commit 4f366c116a614241606c85b7156c33a91ed1cd0f) Bug: 485187423,481634944 Change-Id: Ice8eb4c12e902d63aa3efae9fc900cb08c217da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7595542 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7559@{#4737} Cr-Branched-From: 223dfbac1c7542a06b422390d954afe5b560b607-refs/heads/main@{#1552494}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.