Google Git
Sign in
chromium / chromium / src / 5ca13cd261c1d93589582746811bb1a3a0be56d8
commit5ca13cd261c1d93589582746811bb1a3a0be56d8[log] [tgz]
authorNoah Rose Ledesma <noahrose@google.com>Mon Jan 30 21:15:11 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jan 30 21:15:11 2023
tree624a9fb28114a628ae948cf9d0961c1b4bc83e56
parent34d875ec2477e96203638a06271c02a3588253b9 [diff]
Run LibcurlNetworkFetcher in a single sequence

The libcurl network fetcher needs to use weak pointers. The weak pointer
factory needs to be destroyed on the same sequence that the weak
pointers are dereferenced on. The previous code violated this invariant,
destroying the factory on the sequence that the fetcher was created on
while dereferencing on the IO sequence.

To avoid this issue, the fetcher has been refactored to run on a single
sequence. An intermediate class has been added to manage the sequence
bound object.

Bug: 1410783
Change-Id: I16603e3944d56c64887adb6f48fb92364c1f379f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4200710
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Cr-Commit-Position: refs/heads/main@{#1098858}
1 file changed
tree: 624a9fb28114a628ae948cf9d0961c1b4bc83e56
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.