Google Git
Sign in
chromium / chromium / src / 5ccc972daca378da83a27b1ed48fdb92d32e075b
commit5ccc972daca378da83a27b1ed48fdb92d32e075b[log] [tgz]
authorLijin Shen <lazzzis@google.com>Mon Jul 11 18:48:16 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jul 11 18:48:16 2022
treea2e99149e75f1426161a4e7397e5f7834aef41bc
parent3ce948aa0583b35402633fc24d4421ad1a54f8f9 [diff]
[M103][Messages][SaveCard] Reset metric recording related variables.

ChromeAutofillClient is instantiated once per WebContents; it's possible
to trigger save card prompts multiple times.

Some variables, like is_dialog_show_, if set true, should be reset
after promotion is completed; otherwise, some metrics are wrongly
recorded.

(cherry picked from commit e4e581ca2bd1ba641bf52da0b2d62ddc4e2dec2c)

Bug: 1190531, 1337107
Change-Id: I962078bca3975f6dfa02f64306a73bd717daf0b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3710952
Reviewed-by: Elizabeth Popova <lizapopova@google.com>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1015544}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3754070
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#1195}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
2 files changed
tree: a2e99149e75f1426161a4e7397e5f7834aef41bc
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.