Google Git
Sign in
chromium / chromium / src / 5cdb85b3742e11a7c10113a765518dfffb5ae4d0
commit5cdb85b3742e11a7c10113a765518dfffb5ae4d0[log] [tgz]
authorAlex Gough <ajgo@chromium.org>Tue Apr 02 17:47:22 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 02 17:47:22 2024
tree9642e5d115304eba20726a1a4dbbb090129ae076
parent374bd4d55d4fc78baae61d2c59bfeb2d9d99bd07 [diff]
Prevent headless from opening a console in children

https://chromium-review.googlesource.com/c/chromium/src/+/5373414
added logging related arguments to child processes if logging
was enabled, but these confused --headless chrome which opened
a console from children.

This change moves evaluation of --headless earlier so that
consoles are never created in headless mode.

(cherry picked from commit c9a1edeb71530ec023564740ffe592be6b5a6fb8)

Bug: 331806515
Change-Id: Idd8766a662d0c8293a0aad9dc791fddf6b428eec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406360
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Peter Kvitek <kvitekp@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1280387}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410334
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/branch-heads/6367@{#483}
Cr-Branched-From: d158c6dc6e3604e6f899041972edf26087a49740-refs/heads/main@{#1274542}
1 file changed
tree: 9642e5d115304eba20726a1a4dbbb090129ae076
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.