Google Git
Sign in
chromium / chromium / src / 5ced8e4e8ac2d00cc55d5030edfdfc1ba10190ad
commit5ced8e4e8ac2d00cc55d5030edfdfc1ba10190ad[log] [tgz]
authorNate Chapin <japhet@chromium.org>Tue Aug 25 22:17:32 2020
committerCommit Bot <commit-bot@chromium.org>Tue Aug 25 22:17:32 2020
tree7b7295910565d82ffbc2253b29987c729651b5d5
parentd2f3749c22c442455d3b3c25571ddea0b7c6c31a [diff]
Don't send DidStartProvisionalLoad notifications for JS urls and XSLT documents

We typically expect DidStartProvisionaLoad messages to be paired with a
DidCommitLoad when the navigation is successful. For pseudo-navigations like
XSLT processing and javascript: urls, we skip the DidCommitLoad message.
If we do not also skip the DidStartProvisionalLoad message, listeners that
expect these notifications to be paired will get confused (e.g., the
inspector debugger may leave breakpoints disabled in the new Document).

Bug: 1095920
Change-Id: I5bdd18b3f4103d5d2c52fe48060c1114efb21b0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254818
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801573}
5 files changed
tree: 7b7295910565d82ffbc2253b29987c729651b5d5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.