Google Git
Sign in
chromium / chromium / src / 5d01f316e8addae364d7406961e5327177d11594
commit5d01f316e8addae364d7406961e5327177d11594[log] [tgz]
authorBasia Zimirska <basiaz@google.com>Fri Sep 05 17:49:00 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Sep 05 17:49:00 2025
tree5c30428499a88f87163e90d6f632e47b93f71288
parent6963b7a8cf1241739c06d29abf14fa1a4e5f74fa [diff]
Reland "[Glic] Make side panel and action react to eligibility changes."

This reverts commit da7c2a8ca96fbfdc0774e500b75ef80d1cac2d44.

Reason for revert: I added missing features in the test setup. Verified that after running chromium.win:Win10 Tests x64|browser_tests_no_field_trial as instructed, GlicSidePanelCoordinator tests are not failing anymore.

Bug: 441349768
Original change's description:
> Revert "[Glic] Make side panel and action react to eligibility changes."
>
> This reverts commit e8600bb8b702df6a2538e410ff77d56d06e6a9d2.
>
> Reason for revert: https://ci.chromium.org/ui/p/chromium/builders/ci/Win10%20Tests%20x64
>
> Sample failure:
> https://ci.chromium.org/ui/p/chromium/builders/ci/Win10%20Tests%20x64/103330/overview
>
> Bug: 441349768
> Original change's description:
> > [Glic] Make side panel and action react to eligibility changes.
> >
> > Eligibility state can change after side panel entry and browser actions are added.
> >
> > When profile becomes eligible: side panel entry is registered and browser action becomes visible
> > When profile becomes ineligible:  browser action is hidden, side panel is closed and un registered, observer removed
> >
> >
> > Bug: 441349768
> > Change-Id: I168f66bd5b8cd2bf398a6c7bd10e1753b67ceb6d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6898320
> > Commit-Queue: Basia Zimirska <basiaz@google.com>
> > Reviewed-by: Ian Wells <iwells@chromium.org>
> > Reviewed-by: Trevor Perrier <perrier@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1510981}
>
> Bug: 441349768
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: I7ef6ad632e7b7af3578df823615226aa737d35c8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6917228
> Owners-Override: Minoru Chikamune <chikamune@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Auto-Submit: Minoru Chikamune <chikamune@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1511245}

Bug: 441349768
Change-Id: Ifa5f15c5cfaa27f0f45f6c812d4ffee90197f8f7

Include-Ci-Only-Tests: chromium.win:Win10 Tests x64|browser_tests_no_field_trial
Change-Id: Ifa5f15c5cfaa27f0f45f6c812d4ffee90197f8f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6918072
Reviewed-by: Ian Wells <iwells@chromium.org>
Commit-Queue: Basia Zimirska <basiaz@google.com>
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1511714}
9 files changed
tree: 5c30428499a88f87163e90d6f632e47b93f71288
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. clusterfuzz-data
  52. internal
  53. ios_internal
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .cursorignore
  60. .geminiignore
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. SECURITY_OWNERS
  88. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.