Don't crash in TestRecipeReplayer::AllAssertionsPassed We had a hard crash: Check failed: is_ok(). Can't ExtractBool() because the script encountered a problem: a JavaScript error: "RenderFrame deleted." if TestRecipeReplayer::AllAssertionsPassed(). Instead of CHECK()ing, the the AllAssertionsPassed() function now fails gracefully. It is called in WaitForElementToBeReady(), so hopefully the code becomes more robust against ongoing navigations by retrying steps instead of crashing. Bug: 446080325 Change-Id: I673def4834a78a5b7c72a1f11bc1fa96554dfa9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7002866 Commit-Queue: Dominic Battre <battre@chromium.org> Reviewed-by: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/main@{#1524192}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.