Google Git
Sign in
chromium / chromium / src / 5d401bb500b4cb9ba1f724ee022f43307db5b1cc
commit5d401bb500b4cb9ba1f724ee022f43307db5b1cc[log] [tgz]
authorChristoph Schwering <schwering@google.com>Fri Dec 01 16:39:08 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Dec 01 16:39:08 2023
tree54dcb009f87a1adb4339c3a31e857c2699961bde
parentea9245e68c72959b5e0f661c167e2c7b448dcc7a [diff]
[Autofill] Add and use FormDataImporterTestApi

This CL introduces FormDataImporterTestApi to make the non-private API
of FormDataImporter more accessible and to make it clear when tests
are testing the contract or internals of FormDataImporter.

A followup step to reduce test complexity could be to inject
AddressProfileSaveManager, CreditCardSaveManager, IbanSaveManager,
VirtualCardEnrollmentManager, rather than creating them in
in FormDataImporter(). Currently tests first create a standard
FormDataImporter and then tweak the private variables.

Bug: 1119526
Change-Id: I5d4fc9ad95fb172a27728a50b5f79899ca005194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038695
Reviewed-by: Dominic Battre <battre@chromium.org>
Reviewed-by: Jan Keitel <jkeitel@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Emily Shack <emshack@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/main@{#1231972}
14 files changed
tree: 54dcb009f87a1adb4339c3a31e857c2699961bde
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.