Google Git
Sign in
chromium / chromium / src / 5d4dece0d6035e963e6fad11938c74a11c447362
commit5d4dece0d6035e963e6fad11938c74a11c447362[log] [tgz]
authorRyan Sultanem <rsult@google.com>Tue May 20 14:06:41 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 20 14:06:41 2025
tree9313411a671d6742fe3d4b8c33fd06b28ab34b6c
parent366f69eb20b9ea064c3742337688d6e4e6fc7ae4 [diff]
[M137] [B4B] Fix getting default parent for managed nodes

Original change's description:
> [B4B] Fix getting default parent for managed nodes
> 
> Some operations are allowed for managed nodes, such as opening the
> bookmark manager after selecting a managed node through the context
> menu.
> 
> The code previously did not allow that since it assumed this was only
> used to get the parent to create new nodes, which is not allowed for
> managed bookmarks.
> 
> Add a method specific for managed nodes in the MergedService to
> expose that this is an accepted operation but that it should be
> treated differently than the regular nodes.
> 
> Fixed: 414129879
> Change-Id: I4771a41cbc53cba1ce82c6eb46e44e7da3c4eaf3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6540051
> Reviewed-by: David Roger <droger@chromium.org>
> Commit-Queue: Ryan Sultanem <rsult@google.com>
> Cr-Commit-Position: refs/heads/main@{#1459515}

Bug: 418679088,414129879
Change-Id: I4771a41cbc53cba1ce82c6eb46e44e7da3c4eaf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6568290
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7151@{#1393}
Cr-Branched-From: 8e0d32ed6e49a2415b16e5ed402957cac2349ce2-refs/heads/main@{#1453031}
7 files changed
tree: 9313411a671d6742fe3d4b8c33fd06b28ab34b6c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.